08:53 MrCooper: review of https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41845 would be appreciated, fixes an EGL GBM platform oopsie which is hitting mutter users
12:03 lumag: mripard: sorry for being PITA, could you please reply to https://lore.kernel.org/dri-devel/vpd5hyote5wspmlpad64kf5peoy5g7wv6c7xjn6ammcmjtai7r@q2tarmr5aoqn/ ?
14:07 mripard: lumag: done, sorry I completely missed your answer
16:54 alyssa: glehmann: i'm still chewing on "nir/algebraic: Convert bcsel of addition to addition of"
16:54 alyssa: if anything Intel would prefer the other way around since we can predicate the addition
16:54 alyssa: in reality no Intel compilers on any OS currently do that and IDK if it's profitable for cycle count even tho it saves an instr
16:55 alyssa: but I guess for common optimizations having a canonical form is good regardless
16:55 alyssa: I think nvidia predication is similar to intel
16:57 glehmann: I think nv has compares fused with b2i/b2f, so it could go either way
16:58 glehmann: b + b2f(a) is also more fma friendly
16:58 glehmann: and in aco we optimize b + b2i(a) to add_carry_in(b, 0, a)
16:59 glehmann: but yeah, all of this kind of depends on backend details
17:00 karolherbst: I think nv has compares fused with b2i/b2f, so it could go either way not anymore
17:01 karolherbst: uhm.. I wnated to quote that
17:01 karolherbst: ohh or maybe we still have? mhh
17:02 karolherbst: ahh only compare and b2f
17:02 karolherbst: the int one is gone
17:02 Company: robertmader[m]: Can I get your blessings on https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41776 ?
17:02 glehmann: I was about to say, I clearly see the b2f version in nak :D
17:02 karolherbst: FSET is kinda funky, because you can even chain an input bool
17:02 karolherbst: so b2f((a <= b) || c) is one instruction
17:02 Company: Also, do you know who the right person is to poke to get it reviewed and assigned to marge?
17:03 karolherbst: but yeah.. we only have ISETP, so..
17:03 karolherbst: that writes a predicate
17:04 karolherbst: glehmann: but also.. NAK covers ... 13 years of hardware? 🙃
17:04 karolherbst: I'm sure it supports hardware were we had this for ints still
17:06 karolherbst: or maybe it was always float only...
17:07 karolherbst: nahh.. it was the same instruction back then.. the code is confusing
17:27 alyssa: glehmann: you'd think we could do the same trick with ADDC on Intel, but you'd be wrong (:
17:28 alyssa: ADDC/SUBB on Intel are.. deeply cursed
17:28 alyssa: mesa has never used them
17:29 glehmann: I'm starting to think it's easy if you list the non cursed features
17:29 alyssa: Oh uh
17:29 alyssa: Um
17:30 alyssa: Well there's Larrabee
17:33 HdkR: alyssa: non-cursed hardware, not cursed hardware!
17:35 karolherbst: okay.. I figured out that nir_opt_dead_write_vars became really slow and I got a fix: https://gitlab.freedesktop.org/karolherbst/mesa/-/commit/d7e888525d3fb7159d55c8edfb33cd7705f0351e
17:35 karolherbst: speeds up some compilations by a factor of 3x
17:36 karolherbst: I should prolly move it to an MR
17:39 glehmann: the joy of linked lists
17:46 karolherbst: will check if it also helps with fossils to get some better numbers than "this one compute benchmark does not compile for that long anymore" 🙃
17:56 jani: hey, has anyone seen a panel failure mode where it rotates red/green/blue/black/white? feels like a test mode or something. really curious. video at https://gitlab.freedesktop.org/drm/i915/kernel/-/work_items/15922#note_3491200
17:58 jani: also, heisenbug. starting screen recording stops the color rotation