08:55ofourdan: MrCooper, jadahl, emersion, anything to add to https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1088 before I press the green^W blue button?
09:00MrCooper: ofourdan: nothing from my side
09:09jadahl: nothing from me either
09:39emersion: i disagree with jadahl but i'll leave it up to you to decide what to do
09:40ofourdan: emersion, you mean you disagree on the form, not on the logic itself, right?
09:43emersion: i think the patch degrades readability and maintainability
09:43emersion: the idea is good
09:43ofourdan: for context, this is to fix a regression triggered by commit c6f2598a4 so we need a fix
09:43emersion: i understand
11:38wlb: weston/main: Derek Foreman * compositor: Rename position.set to position.changed https://gitlab.freedesktop.org/wayland/weston/commit/ff00ae421851 include/libweston/libweston.h libweston/compositor.c
11:38wlb: weston Merge request !1185 merged \o/ (compositor: Rename position.set to position.changed https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/1185)
12:17ifreund: does Xwayland have release notes or a changelog somewhere? All I see in the repository are plain tags
12:28ofourdan: of course it does - the changelog is in git, and the release notes are with the release announcements
12:30ifreund: ok, I think I've just failed to find the release announcements then
12:30ifreund: I assume they're on a mailing list I'm not subscribed to currently or something
12:30ofourdan: https://lists.x.org/archives/xorg/2023-February/061265.html
12:31ifreund: thanks!
12:31ofourdan: np!
12:32pq: that's odd, I thought I was on the xorg list, but I haven't got anything since 2020...
12:32ifreund: ofourdan: I'm very thankful for your work on improving rootful mode by the way, I have one particularly problematic program that I can't get working in my compositor's rootless mode :)
12:33ofourdan: nice, thanks!
12:33ifreund: If it had clipboard integration and the window could be resized I'd seriously consider dropping xwayland support from my compositor xD
12:33kennylevinsen: My (somewhat toy) compositor is also xwayland-less, so I rely entirely on rootful mode where I need X. So much appreciated :)
12:33ifreund: not sure if those things are feasible though
12:34pq: also no xorg-devel emails in 6 months...
12:34pq: and the last members@x.org email was in 2020 too, what is this
13:38wlb: weston Merge request !1186 opened by Leandro Ribeiro (leandrohrb) Add color-profile and color-transformation debug scopes https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/1186
14:32MrCooper: jadahl: to be nitpicky, I think https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1088 would be easier to understand & review if the last commit was split into two (one for each case), and those commits were moved before the commit which actually fixes the issue
14:33ofourdan: (and adding your s-o-b would be great)
14:33ofourdan: I can hold on the xwayland 23.1 rc2 a little bit more
14:57jadahl: MrCooper: alright
15:41ofourdan: jadahl: sorry :)
15:45jadahl: ofourdan: sloppy code moving from my side
15:46ofourdan: also michel was asking to split the commit into two one for each case
15:46jadahl: gah, right
15:50jadahl: ugh, git history rewriting is not fun when you move code
15:50ofourdan: that's right
16:05MrCooper: jadahl: I'm sorry, but I do think it worked out as I hoped, thanks!
16:07jadahl: MrCooper: I had to rewrite a patch, but at least vim's undo feature did half the work
16:08MrCooper: aren't we supposed to use ChatGPT for this now? :P
16:09ofourdan: huh
16:09jadahl: "Rewrite git history according to MrCooper's wishes please" will it work?
16:09ofourdan: gotta try...
16:09MrCooper: I'll be disappointed if it doesn't
16:10ofourdan: ok, I'm going to land this now, and the release of rc2 will probably wait for tomorrow morning, I do not want to rush it
16:10ofourdan: (also I have to add these commits to the backport MR)
16:13MrCooper: sounds good
16:15ofourdan: MrCooper: regarding https://gitlab.freedesktop.org/xorg/xserver/-/issues/1442 anything I could do to help? I am running out of ideas right now
16:17MrCooper: ofourdan: you've done a lot already, can't think of anything else right now; will take another look when I get a chance
16:17emersion: MrCooper: for_each_safe is not safe when any element other than the current one is removed
16:18emersion: not sure if that helps, but i haven't seen it mentionned in your comments, so just in case…
16:18MrCooper: it might help, thanks
16:19emersion: a common pattern to remove everything from a list would be `while (!wl_list_empty(&list))`
16:20emersion: and yeah moving into another temp list as you do is another pattern
16:21ofourdan:facepalm, I never realised that the implementation of wl_list_* is actually the same as xorg_list_*
16:22emersion: and it's all the same as the kernel's!
16:22emersion: beware though, the idea is the same, but the APIs are different
16:22emersion: e.g. xorg insertion has reversed arg order
16:22emersion: when compared to wl at least
16:22ofourdan: we all need some traps here and there to remain alert, aren't we? :)
16:23emersion: it keeps us sharp :)
16:23ofourdan: hehehe
19:30DodoGTA: Is it possible to have a cursor that is always shown and unlocked but locked to one place while holding right-click (while relative mouse events are still being sent) on Wayland?
19:32DodoGTA: Assuming both relative-pointer and pointer-constraints are available and working
19:42DodoGTA: Edit: The relative mouse events should only be sent while right-clicking (this is for clarity reasons)