15:37 devank: hello
17:42 wlb: weston Issue #813 opened by Joan Torres (joantolo) Cursor not updating image https://gitlab.freedesktop.org/wayland/weston/-/issues/813
22:15 aleasto: should I expect a performance penalty in using wp_viewport.set_destination for scaling instead of wl_surface.set_buffer_scale ?
22:17 orowith2os[m]: aleasto: why should you?
22:17 orowith2os[m]: And afaik those two are not mutually exclusive
22:18 orowith2os[m]: set_destination sets the window size, set_buffer_scale sets the window scale size in integer form (use the fractional scale protocol for fractional scaling)
22:18 aleasto: i know they're not mutually exclusive
22:19 orowith2os[m]: The only time you should expect a performance penalty is when relying on integer scaling when the compositor has a fractional scale set for you
22:20 aleasto: i'm implementing fractional scaling for my application. i was wondering if i should keep using set_buffer_scale for integer scales or if i should just go with viewporter for everything
22:20 orowith2os[m]: Still not sure how set_destination matters here, as a "this instead of set_buffer_scale"
22:21 orowith2os[m]: Set_destination doesn't give you the scale, it gives you the size
22:22 aleasto: right, so either i say that the buffer should be interpreted as double the size, or i provide the destination size as half of the buffer
22:22 aleasto: (in an example with scale=2)
22:22 orowith2os[m]: Ah, English, fun
22:23 orowith2os[m]: That's better
22:23 orowith2os[m]: Iirc you're supposed to multiply the size by the scale and submit that
22:24 orowith2os[m]: Or, something like that
22:24 orowith2os[m]: Like, multiply a 1920x1080 monitor size by 0.75 for 75% scaling and you use that resolution instead. Hoping the concepts apply here.
22:24 orowith2os[m]: Will let someone else come along and pick this up, probably
22:25 aleasto: i'm not asking for advice on the implementation, i have both versions already implemented
22:27 orowith2os[m]: Er, yeah, got a bit sidetracked
22:27 orowith2os[m]: Tl;Dr use viewporter where possible ig?
22:29 orowith2os[m]: New protocols good 👍
22:35 orowith2os[m]: Oh, I see where I got confused >>
22:36 orowith2os[m]: Maybe?
22:36 orowith2os[m]: Eh, I'll just leave it
22:38 aleasto: from the description of fractional-scale-v1:
22:38 aleasto: A client can submit scaled content by utilizing wp_viewport. This is done by creating a wp_viewport object for the surface and setting the destination rectangle to the surface size before the scale factor is applied.
22:39 aleasto: i'm wondering if doing that should be assumed to be more expensive than using wl_surface.set_buffer_scale when i know that the scale is integer
22:45 orowith2os[m]: I'd assume not? The compositor would scale it appropriately in the end
22:45 zamundaaa[m]: Both have exactly the same performance cost - in 95% of situations, none
22:46 aleasto: thank you :)
23:00 danieldg: there's a tiny cost from the server needing to do a bit of math to figure out your viewport plus the integer scaling is a no-op, but that's so small in comparison to an actual rescale you can't measure it
23:35 aleasto: thanks